Skip to content

Commit

Permalink
Fix compile errors in Combine (#11610)
Browse files Browse the repository at this point in the history
#11231 introduces some renamed methods, which broke the Combine build, see this workflow run: firebase/firebase-ios-sdk/actions/runs/5665691823

This PR should fix this.
  • Loading branch information
peterfriese authored Jul 26, 2023
1 parent 00dad35 commit 959cf0d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
7 changes: 6 additions & 1 deletion FirebaseCombineSwift/Tests/Unit/Auth/AuthMocks.swift
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,17 @@ extension AuthBackendImplementationMock {
fatalError("You need to implement \(#function) in your mock.")
}

func getRecaptchaConfig(_ request: FIRGetRecaptchaConfigRequest,
callback: @escaping FIRGetRecaptchaConfigResponseCallback) {
fatalError("You need to implement \(#function) in your mock.")
}

func resetPassword(_ request: FIRResetPasswordRequest,
callback: @escaping FIRResetPasswordCallback) {
fatalError("You need to implement \(#function) in your mock.")
}

func post(with request: FIRAuthRPCRequest, response: FIRAuthRPCResponse,
func call(with request: FIRAuthRPCRequest, response: FIRAuthRPCResponse,
callback: @escaping (Error?) -> Void) {
fatalError("You need to implement \(#function) in your mock.")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class SignInWithGameCenterTests: XCTestCase {
var contentType: String?
var handler: FIRAuthBackendRPCIssuerCompletionHandler?

func asyncPostToURL(with requestConfiguration: FIRAuthRequestConfiguration, url URL: URL,
func asyncCallToURL(with requestConfiguration: FIRAuthRequestConfiguration, url URL: URL,
body: Data?, contentType: String,
completionHandler handler: @escaping FIRAuthBackendRPCIssuerCompletionHandler) {
requestURL = URL
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetOOBConfirmationCodeResponse.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetProjectConfigRequest.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetProjectConfigResponse.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetRecaptchaConfigRequest.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetRecaptchaConfigResponse.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRResetPasswordRequest.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRResetPasswordResponse.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRRevokeTokenRequest.h"
Expand Down

0 comments on commit 959cf0d

Please sign in to comment.