Review

firebase · Nov 2, 2023 · cc67a7b · cc67a7b
1 parent 70bb100
commit cc67a7b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/ReleaseTooling/Sources/FirebaseManifest/Pod.swift b/ReleaseTooling/Sources/FirebaseManifest/Pod.swift
@@ -54,11 +54,4 @@ public struct Pod {
   public func podspecName() -> String {
     return "\(name).podspec"
   }
-
-  /// The Firebase pod does not support import validation with Xcode 12 because of the deprecated
-  /// ML pods not supporting the ARM Mac slice. While all other pods support
-  // it, it is skipped to decrease the time it takes to stage and publish them.
-  public func skipImportValidation() -> String {
-    return "--skip-import-validation"
-  }
 }
diff --git a/ReleaseTooling/Sources/FirebaseReleaser/Push.swift b/ReleaseTooling/Sources/FirebaseReleaser/Push.swift
@@ -48,12 +48,11 @@ enum Push {
         switch destination {
         case .staging:
           return "pod repo push --skip-tests --use-json \(warningsOK) \(stagingLocation) " +
-            pod.skipImportValidation() + " \(pod.podspecName()) " +
+            "--skip-import-validation" + " \(pod.podspecName()) " +
             "--sources=\(stagingRepo).git,https://cdn.cocoapods.org"
         case .trunk:
           return "pod trunk push --skip-tests --synchronous \(warningsOK) " +
-            pod
-            .skipImportValidation() + " ~/.cocoapods/repos/\(stagingLocation)/\(pod.name)/" +
+            "--skip-import-validation" + " ~/.cocoapods/repos/\(stagingLocation)/\(pod.name)/" +
             "\(manifest.versionString(pod))/\(pod.name).podspec.json"
         }
       }()