add pipeline interface in cocoapods support

firebase · Dec 13, 2024 · f0288cd · f0288cd
1 parent 681f6b3
commit f0288cd
Show file tree

Hide file tree

Showing 7 changed files with 283 additions and 234 deletions.
diff --git a/Firestore/Example/Firestore.xcodeproj/project.pbxproj b/Firestore/Example/Firestore.xcodeproj/project.pbxproj
diff --git a/Firestore/Source/API/FIRFirestore+Internal.h b/Firestore/Source/API/FIRFirestore+Internal.h
@@ -79,8 +79,6 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (const std::shared_ptr<firebase::firestore::util::AsyncQueue> &)workerQueue;
 
-@property(nonatomic, assign, readonly) std::shared_ptr<api::Firestore> wrapped;
-
 @property(nonatomic, assign, readonly) const model::DatabaseId &databaseID;
 @property(nonatomic, strong, readonly) FSTUserDataReader *dataReader;
 

diff --git a/Firestore/Source/Public/FirebaseFirestore/FIRFirestore.h b/Firestore/Source/Public/FirebaseFirestore/FIRFirestore.h
@@ -15,6 +15,7 @@
  */
 
 #import <Foundation/Foundation.h>
+#import <memory>
 
 #import "FIRListenerRegistration.h"
 
@@ -30,6 +31,16 @@
 @class FIRWriteBatch;
 @class FIRPersistentCacheIndexManager;
 
+namespace firebase {
+namespace firestore {
+namespace api {
+class Firestore;
+}  // namespace api
+}  // namespace firestore
+}  // namespace firebase
+
+namespace api = firebase::firestore::api;
+
 NS_ASSUME_NONNULL_BEGIN
 
 /**
@@ -91,6 +102,8 @@ NS_SWIFT_NAME(Firestore)
  */
 + (instancetype)firestoreForDatabase:(NSString *)database NS_SWIFT_NAME(firestore(database:));
 
+@property(nonatomic, assign, readonly) std::shared_ptr<api::Firestore> wrapped;
+
 /**
  * Custom settings used to configure this `Firestore` object.
  */

diff --git a/Firestore/Swift/Source/AsyncAwait/Firestore+AsyncAwait.swift b/Firestore/Swift/Source/AsyncAwait/Firestore+AsyncAwait.swift
@@ -115,4 +115,8 @@ public extension Firestore {
       }
     }
   }
+
+  func pipeline() -> PipelineSource {
+    return PipelineSource(firebase.firestore.api.FirestorePipeline.pipeline(wrapped))
+  }
 }
diff --git a/Firestore/Swift/Source/SwiftAPI/PipelineSource.swift b/Firestore/Swift/Source/SwiftAPI/PipelineSource.swift
@@ -0,0 +1,14 @@
+//
+//  PipelineSource.swift
+//  Pods
+//
+//  Created by Cheryl Lin on 2024-12-12.
+//
+
+public class PipelineSource {
+  let cppPtr: firebase.firestore.api.PipelineSource
+
+  public init(_ cppSource: firebase.firestore.api.PipelineSource) {
+    cppPtr = cppSource
+  }
+}
diff --git a/Firestore/core/swift/include/firestore_pipeline.h b/Firestore/core/swift/include/firestore_pipeline.h
@@ -15,7 +15,7 @@ class Firestore;
 
 class FirestorePipeline {
  public:
-  PipelineSource pipeline(std::shared_ptr<Firestore> firestore);
+  static PipelineSource pipeline(std::shared_ptr<Firestore> firestore);
 };
 
 }  // namespace api

diff --git a/Package.swift b/Package.swift
@@ -1412,6 +1412,7 @@ func firebaseFirestoreCppTarget() -> Target {
       "FirebaseAppCheckInterop",
       "FirebaseCore",
       "leveldb",
+      "FirebaseFirestoreInternalWrapper",
       .product(name: "nanopb", package: "nanopb"),
     ],
     path: "Firestore/core/swift",
-Original file line number
+Diff line change
@@ Expand Up / @@ -115,4 +115,8 @@ public extension Firestore { @@
           }
         }
       }
+      func pipeline() -> PipelineSource {
+        return PipelineSource(firebase.firestore.api.FirestorePipeline.pipeline(wrapped))
+      }
     }