[Firestore] Expose error in LoadBundleTaskProgress #10455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagates errors, if any, from the underlying LoadBundleTaskProgress C++ type to the FIRLoadBundleTaskProgress in the ObjC layer. This allows callers to inspect the type of error that occurred when observing bundle loading progress using the addObserver API in FIRLoadBundleTask. Needs API review.
|
Please close, merge, or comment. We plan to close stale PRs on November 28, 2023. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagates errors, if any, from the underlying
LoadBundleTaskProgressC++ type toFIRLoadBundleTaskProgressin the ObjC layer. This allows callers to inspect the type of error that occurred when observing bundle loading progress using theaddObserver:API inFIRLoadBundleTask.In its current form, callers can check whether an error occurred by looking at
FIRLoadBundleTaskProgress'sstatebut cannot retrieve any details about the error. However, error details are already exposed when using theloadBundle:completion:API inFIRFirestore.Needs API review.