Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FB sdk to v14 #10785

Closed
wants to merge 6 commits into from
Closed

Update FB sdk to v14 #10785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2662a13
Update FB sdk to v14
Feb 7, 2023
f645e1e
Update FacebookAuthTests.m
Feb 8, 2023
2977069
Update FacebookAuthTests.m
Apr 27, 2023
bf1a053
Update Podfile
Nov 15, 2023
01fff2b
Update Podfile
Nov 15, 2023
c67c0f2
Update Podfile
Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions FirebaseAuth/Tests/Sample/ApiTests/FacebookAuthTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ @interface FacebookAuthTests : FIRAuthApiTestsBase

@implementation FacebookAuthTests

// TODO(#10752) - Update and fix the Facebook login Sample app and tests.
- (void)SKIPtestSignInWithFaceboook {
- (void)testSignInWithFaceboook {
FIRAuth *auth = [FIRAuth auth];
if (!auth) {
XCTFail(@"Could not obtain auth object.");
Expand Down Expand Up @@ -77,8 +76,7 @@ - (void)SKIPtestSignInWithFaceboook {
[self deleteFacebookTestingAccountbyId:facebookAccountId];
}

// TODO(#10752) - Update and fix the Facebook login Sample app and tests.
- (void)SKIPtestLinkAnonymousAccountToFacebookAccount {
- (void)testLinkAnonymousAccountToFacebookAccount {
FIRAuth *auth = [FIRAuth auth];
if (!auth) {
XCTFail(@"Could not obtain auth object.");
Expand Down Expand Up @@ -143,7 +141,7 @@ - (NSDictionary *)createFacebookTestingAccount {
__block NSData *data = nil;
[fetcher beginFetchWithCompletionHandler:^(NSData *receivedData, NSError *error) {
if (error) {
NSLog(@"Creating Facebook account finished with error: %@", error);
NSLog(@"Error: Creating Facebook account finished with error: %@", error);
return;
}
data = receivedData;
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Tests/Sample/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ target 'AuthSample' do
pod 'FirebaseCoreInternal', :path => '../../../'
pod 'FirebaseAuth', :path => '../../../', :testspecs => ['unit']
pod 'FirebaseInstallations', :path => '../../..'
pod 'FBSDKLoginKit', '< 13'
pod 'FBSDKLoginKit', '~> 15'
pod 'GoogleSignIn', '~> 6'
pod 'GTMSessionFetcher/Core'
pod 'RecaptchaEnterprise', '~> 18.3'
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Tests/Sample/Sample/FacebookAuthProvider.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ - (void)getAuthCredentialWithPresentingViewController:(UIViewController *)viewCo
[self signOut];

[ApplicationDelegate setOpenURLDelegate:self];
[FBSDKSettings setAppID:kFacebookAppID];
[FBSDKSettings.sharedSettings setAppID:kFacebookAppID];
[_loginManager logInWithPermissions:@[ @"email" ]
fromViewController:viewController
handler:^(FBSDKLoginManagerLoginResult *result, NSError *error) {
Expand Down
Loading