Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to #import <Foundation/Foundation.h> in FIRAppCheckProtocol.h #11864

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Switch to #import <Foundation/Foundation.h> in FIRAppCheckProtocol.h #11864

merged 1 commit into from
Sep 28, 2023

Conversation

andrewheard
Copy link
Contributor

This is a no-op change externally but requires one less transformation for use internally (where modules aren't supported).

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review September 28, 2023 15:57
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.09% (21c38d4) to 88.09% (7489443) by -0.00%.

    FilenameBase (21c38d4)Merge (7489443)Diff
    leveldb_mutation_queue.cc93.56%92.42%-1.14%
    leveldb_remote_document_cache.cc94.83%96.55%+1.72%
    task.cc93.91%94.78%+0.87%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dAdauRKoQD.html

@andrewheard andrewheard merged commit 0e7e4f9 into master Sep 28, 2023
@andrewheard andrewheard deleted the ah/foundation-import branch September 28, 2023 18:37
@firebase firebase locked and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: appcheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @google-oss-bot @paulb777