Upgrade grpc for cocoapods #11866
Closed
Upgrade grpc for cocoapods #11866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
dconeybe
reviewed
Sep 28, 2023
| @@ -100,7 +100,9 @@ Google Cloud Firestore is a NoSQL document database built for automatic scaling, | |||
| s.dependency 'abseil/time', abseil_version | |||
| s.dependency 'abseil/types', abseil_version | |||
|
|
|||
| s.dependency 'gRPC-C++', '~> 1.44.0' | |||
| s.dependency 'gRPC', '~> 1.57.0' | |||
There was a problem hiding this comment.
FYI I think you'll need to upgrade grpc to at least 1.59.0 in order to pick up the iOS 12 crash fix (grpc/grpc#34416). 1.59.0 is in "prerelease" at the time of writing. Presumably, it will be officially released in the next few weeks.
There was a problem hiding this comment.
Yeah, this is only to test if we can upgrade at all. Will do 1.59 later.
|
Closing since we've now updated to 1.62.* |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.