Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Passkey #1 cloned] start passkey enrollment rpc #11872

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[Passkey #1 cloned] start passkey enrollment rpc #11872

merged 1 commit into from
Oct 2, 2023

Conversation

Xiaoshouzi-gh
Copy link
Contributor

Copy of PR #11748

  1. Rebased from master to use the most recent changes from FIRAuthBackend.m.
  2. Added startPasskeyEnrollmentRequest header and implementation
  3. Added startPasskeyEnrollmentResponse header and implementation
  4. Implemented the FIRAuthBackend startPasskeyEnrollment method
  5. Added unit tests.

Changes different from #11748

  • Updated credentialID and userID from NSData to NSString
  • Uses the new request init method initWithEndpoint:requestConfiguration: and update the backend call from postWithRequest to callWithRequest.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@Xiaoshouzi-gh Xiaoshouzi-gh mentioned this pull request Sep 29, 2023
Closed
@Xiaoshouzi-gh
Copy link
Contributor Author

@renkelvin used a new branch for the merge conflicts, please see the following updates

Changes different from #11748

Updated credentialID and userID from NSData to NSString
Uses the new request init method initWithEndpoint:requestConfiguration: and update the backend call from postWithRequest to callWithRequest.

@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review September 29, 2023 17:07
renkelvin
renkelvin approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@renkelvin renkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xiaoshouzi-gh Xiaoshouzi-gh merged commit b8f0972 into passkey-main Oct 2, 2023
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the passkey-start-enroll branch October 2, 2023 03:10
Xiaoshouzi-gh added a commit that referenced this pull request Oct 2, 2023
@Xiaoshouzi-gh
[Passkey #1 cloned] start passkey enrollment rpc (#11872)
1dd888a 
1. implemented rpc call to startPasskeyEnrollment
2. defined startPasskeyEnrollment request and response
3. added unit tests
@firebase firebase locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xiaoshouzi-gh @google-oss-bot @renkelvin