Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth-swift] TOTP #11877

Merged
merged 10 commits into from
Oct 3, 2023
Merged

[auth-swift] TOTP #11877

merged 10 commits into from
Oct 3, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 30, 2023

Reimplement Firebase Auth TOTP support in Swift

This PR does the library code and unit tests. The sample app changes are deferred to a future PR.

#no-changelog

@paulb777 paulb777 marked this pull request as draft October 2, 2023 00:02
@paulb777 paulb777 marked this pull request as ready for review October 3, 2023 02:48
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xiaoshouzi-gh
Copy link
Contributor

quick question - are we going to drop objective-c support after all auth features migrating to swift?

@paulb777
Copy link
Member Author

paulb777 commented Oct 3, 2023

@Xiaoshouzi-gh We may not add Objective-C support for future APIs, but plan to keep existing Objective-C API support from the Swift implementation. All of the public APIs in the auth-swift branch should have the appropriate @objc annotation to do so.

@paulb777 paulb777 merged commit 320feff into auth-swift Oct 3, 2023
17 checks passed
@paulb777 paulb777 deleted the pb-swift-totp branch October 3, 2023 16:49
@firebase firebase locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants