New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Firestore visionOS build on Xcode 15.1 #12029

Merged

paulb777 merged 2 commits into master from pb-fs-xc151-vision

Oct 31, 2023

Member

paulb777 commented Oct 31, 2023


          Fix Firestore visionOS build on Xcode 15.1

acb315d

google-oss-bot added the api: firestore label


          style

2f38885

ncooke3 approved these changes

View reviewed changes

Member

ncooke3 left a comment

LGTM. I'm in the process of staging pods in case there are some unrelated CI failures.

google-oss-bot commented Oct 31, 2023 •

edited

Loading

Coverage Report ¹

Affected Products

FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework
Overall coverage changed from 88.15% (b850d1a) to 88.17% (895ea96) by +0.02%.
Filename Base (b850d1a) Merge (895ea96) Diff
connectivity_monitor_apple.mm 51.92% 52.83% +0.91%
filesystem_apple.mm 83.33% 83.78% +0.45%
leveldb_key.cc 98.14% 98.33% +0.20%
write_stream.cc 91.55% 94.37% +2.82%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/EWUBr18tKy.html

paulb777 merged commit 822f547 into master

39 checks passed

paulb777 deleted the pb-fs-xc151-vision branch

October 31, 2023 20:30

firebase locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels