Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Testing] visionOS build should fail #12035

Closed
wants to merge 1 commit into from

Conversation

andrewheard
Copy link
Contributor

Do not merge. The visionOS, macos-13 compile should fail if it's actually building for visionOS.

#no-changelog

@andrewheard
Copy link
Contributor Author

cc: @paulb777

@andrewheard
Copy link
Contributor Author

andrewheard commented Nov 1, 2023

CI passes on visionOS: https://github.com/firebase/firebase-ios-sdk/actions/runs/6721761101/job/18268182096?pr=12035

I suspect that it's actually building for macOS based on:

--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:x86_64, id:[42](https://github.com/firebase/firebase-ios-sdk/actions/runs/6713168830/job/18244210409#step:5:43)03018E-580F-C1B5-9525-B745CECA79EB }
...

https://github.com/firebase/firebase-ios-sdk/actions/runs/6721761101/job/18268182096?pr=12035#step:5:42

Fails locally:
Screenshot

@andrewheard andrewheard closed this Nov 1, 2023
@paulb777 paulb777 deleted the ah/visionos-compile-test branch November 1, 2023 15:57
@firebase firebase locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants