[NFC] Use angle-bracketed includes in public headers

[ncooke3]

No description provided.

[github-actions]

Apple API Diff Report

Commit: 6930ece
Last updated: Tue Nov 7 06:25 PST 2023
View workflow logs & download artifacts

---

[BUILD ERROR] FirebaseFirestore

---

[google-oss-bot]

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

[google-oss-bot]

Coverage Report ¹

Affected Products

• FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

  Overall coverage changed from 88.09% (a51b4d0) to 88.10% (6930ece) by +0.01%.

  Filename	Base (a51b4d0)	Merge (6930ece)	Diff
  leveldb_mutation_queue.cc	92.42%	93.56%	+1.14%
  local_serializer.cc	87.78%	88.33%	+0.56%
  ordered_code.cc	94.39%	93.90%	-0.49%

• FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

  Overall coverage changed from 72.24% (a51b4d0) to 72.27% (6930ece) by +0.04%.

  Filename	Base (a51b4d0)	Merge (6930ece)	Diff
  FIRRemoteConfig.m	83.91%	84.20%	+0.29%

Test Logs

• Base (a51b4d0): https://github.com/firebase/firebase-ios-sdk/actions/runs/6779974127
• Merge (6930ece): https://github.com/firebase/firebase-ios-sdk/actions/runs/6785815609

1. https://storage.googleapis.com/firebase-sdk-metric-reports/T8K9bejWc5.html

[ncooke3]

When changing the imports from "..." → <...> in the public headers, this surfaced an issue when building the target's test specs (causing most/all of the pod-lib-lint failures on CI).

I also had to change imports of the public headers to the bracket notation to avoid the redefinition errors:

[ncooke3]

I think the issue has to do with the public headers not forward declaring public types where they could be. It would be a breaking change to change that right now though.

[ncooke3]

@paulb777, I'm not too sure about this. Do you see anything troubling about changing all non-public imports of public headers from "..." → <...>?

[paulb777]

I'm not sure. And leaning towards punting since it's a large change on code freeze day.

[ncooke3]

Closing. Will re-open when neeeded for Firebase 11.

[ncooke3]

Linking to #11751