Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Release Tooling] Stage and publish with `--skip-import-valid… #12102

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Revert "[Release Tooling] Stage and publish with `--skip-import-valid… #12102

merged 1 commit into from
Nov 14, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 14, 2023 •
edited
Loading

Restore import validation when publishing pods reverting #12039

Disabling did not noticeably speed up the release.

Faster Macs is a better option 😄

@paulb777 paulb777 requested a review from ncooke3 November 14, 2023 19:25
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 merged commit a0fcb67 into master Nov 14, 2023
39 checks passed
@paulb777 paulb777 deleted the pb-restore-import-validation branch November 14, 2023 20:22
@firebase firebase locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ncooke3