Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth-swift] Add Objective C API build tests #12121

Merged
merged 5 commits into from
Nov 22, 2023
Merged

[auth-swift] Add Objective C API build tests #12121

merged 5 commits into from
Nov 22, 2023

Conversation

paulb777
Copy link
Member

I didn't port the setAPNSToken API since it seems to be a mistake and no-op in the Objective C implementation

@paulb777 paulb777 mentioned this pull request Nov 20, 2023
Merged
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

ncooke3
ncooke3 approved these changes Nov 21, 2023
View reviewed changes
FirebaseAuth/Sources/Swift/Auth/Auth.swift Show resolved Hide resolved
FirebaseAuth/Sources/Swift/Auth/Auth.swift Show resolved Hide resolved
FirebaseAuth/Sources/Swift/Auth/AuthSettings.swift Show resolved Hide resolved
FirebaseAuth/Tests/Unit/ObjCAPITests.m Outdated Show resolved Hide resolved
paulb777
paulb777 commented Nov 21, 2023
View reviewed changes
Copy link
Member Author

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough review!

FirebaseAuth/Sources/Swift/Auth/Auth.swift Show resolved Hide resolved
FirebaseAuth/Sources/Swift/Auth/AuthSettings.swift Show resolved Hide resolved
@paulb777
Copy link
Member Author

Merging. I'll address any additional comments in a subsequent PR

@paulb777 paulb777 merged commit 1ff0d5f into auth-swift Nov 22, 2023
58 of 62 checks passed
@paulb777 paulb777 deleted the pb-as-objc-api branch November 22, 2023 04:54
@firebase firebase locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@renkelvin renkelvin Awaiting requested review from renkelvin

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ncooke3