[Passkey #10] Add sample code for passkey sign in and enrollment #12128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Xiaoshouzi-gh
commented
Nov 21, 2023
|
|
||
| } | ||
|
|
||
| - (ASPresentationAnchor)presentationAnchorForAuthorizationController:(ASAuthorizationController *)controller API_AVAILABLE(ios(13.0)){ |
There was a problem hiding this comment.
Added this because "unrecognized selector sent to instance ..." exception. However this raises a warning of "Category is implementing a method which will also be implemented by its primary class". Any suggestions? @renkelvin
There was a problem hiding this comment.
You can try move this method to MainViewController.m
renkelvin
reviewed
Dec 4, 2023
| [self log:@"OS version is not supported for this action."]; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove unused code.
| }]; | ||
| } | ||
| } else { | ||
| // TODO signInCredential |
|
|
||
| } | ||
|
|
||
| - (ASPresentationAnchor)presentationAnchorForAuthorizationController:(ASAuthorizationController *)controller API_AVAILABLE(ios(13.0)){ |
There was a problem hiding this comment.
You can try move this method to MainViewController.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a passkey section to sample app.
Instructions to run passkey will be included in a different PR.