tests #12133

themiswang · 2023-11-22T16:21:27Z

draft pr

google-oss-bot · 2023-11-22T16:23:13Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.m

FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.h

github-actions · 2023-11-22T21:38:00Z

Apple API Diff Report

Commit: 0653198
Last updated: Thu Nov 23 11:30 PST 2023
View workflow logs & download artifacts

FirebaseCrashlytics

Classes

[MODIFIED] FIRCrashlytics

Swift:
+  class Crashlytics : NSObject
-  class Crashlytics : NSObject
-    class func crashlytics () -> Self
-    func log ( _ msg : String )
-    func log ( format : String , arguments args : CVaListPointer )
-    func setCustomValue ( _ value : Any ?, forKey key : String )
-    func setCustomKeysAndValues ( _ keysAndValues : [ AnyHashable : Any ])
-    func setUserID ( _ userID : String ?)
-    func record ( error : Error )
-    func record ( error : Error , userInfo : [ String : Any ]? = nil )
-    func record ( exceptionModel : ExceptionModel )
-    func didCrashDuringPreviousExecution () -> Bool
-    func setCrashlyticsCollectionEnabled ( _ enabled : Bool )
-    func isCrashlyticsCollectionEnabled () -> Bool
-    func checkForUnsentReports () async -> Bool
-    func checkAndUpdateUnsentReports () async -> CrashlyticsReport ?
-    func sendUnsentReports ()
-    func deleteUnsentReports ()
Objective-C:
+  @interface FIRCrashlytics : NSObject < FIRRolloutsStateSubscriber >
-  @interface FIRCrashlytics : NSObject
-    + ( nonnull instancetype ) crashlytics ;
-    - ( void ) log :( nonnull NSString * ) msg ;
-    - ( void ) logWithFormat :( nonnull NSString * ) format , ...;
-    - ( void ) logWithFormat :( nonnull NSString * ) format arguments :( struct __va_list_tag * ) args ;
-    - ( void ) setCustomValue :( nullable id ) value forKey :( nonnull NSString * ) key ;
-    - ( void ) setCustomKeysAndValues :( nonnull NSDictionary * ) keysAndValues ;
-    - ( void ) setUserID :( nullable NSString * ) userID ;
-    - ( void ) recordError :( nonnull NSError * ) error ;
-    - ( void ) recordError :( nonnull NSError * ) error userInfo :( nullable NSDictionary < NSString * , id > * ) userInfo ;
-    - ( void ) recordExceptionModel :( nonnull FIRExceptionModel * ) exceptionModel ;
-    - ( BOOL ) didCrashDuringPreviousExecution ;
-    - ( void ) setCrashlyticsCollectionEnabled :( BOOL ) enabled ;
-    - ( BOOL ) isCrashlyticsCollectionEnabled ;
-    - ( void ) checkForUnsentReportsWithCompletion :( nonnull void ( ^ )( BOOL )) completion ;
-    - ( void ) checkAndUpdateUnsentReportsWithCompletion : ( nonnull void ( ^ )( FIRCrashlyticsReport * _Nullable )) completion ;
-    - ( void ) sendUnsentReports ;
-    - ( void ) deleteUnsentReports ;

FirebaseRemoteConfig

Classes

FIRRemoteConfig

[ADDED] -addRemoteConfigInteropSubscriber:

Objective-C:
+  - ( void ) addRemoteConfigInteropSubscriber :( nonnull id < FIRRolloutsStateSubscriber > ) subscriber ;

FIRRemoteConfigValue

[ADDED] subscribers

Swift:
+  var subscribers : NSMutableArray { get }
Objective-C:
+  @property ( nonatomic , readonly , nonnull ) NSMutableArray < id < FIRRolloutsStateSubscriber >> * subscribers

themiswang · 2023-11-23T19:28:50Z

FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.m

@@ -23,6 +23,17 @@
 #import "Interop/Analytics/Public/FIRAnalyticsInterop.h"

 @implementation FIRRemoteConfigComponent
+static FIRRemoteConfigComponent *_sharedDefaultAppRemoteConfigSingleton = nil;
+
+ (FIRRemoteConfigComponent *)sharedDefaultAppRemoteConfigSingletonWithDefaultApp:(FIRApp *)app {


We probably need some strategy to create a singleton for the default app Provider and Interop. They will return the same object.

Checked RC Component from Crashlytics and FirePerf, confirm they have the same RC Component: https://screenshot.googleplex.com/9NXgjPbmtxoSrSe

samedson · 2023-11-28T16:19:31Z

Crashlytics/Crashlytics/Public/FirebaseCrashlytics/FIRCrashlytics.h

@@ -16,7 +16,7 @@

 #import "FIRCrashlyticsReport.h"
 #import "FIRExceptionModel.h"
-
+@protocol FIRRolloutsStateSubscriber;


Can we import this?

Yes, this can be imported.

Here's an example where AppCheck imports the AppCheckInterop header in order to declare conformance with the FIRAppCheckProtocol protocol from the interop SDK.

I think it needs to be imported per https://stackoverflow.com/a/11533804/9331576. Were you able to get things building in its current state?

Interesting, I see in codebase that we have some pattern for forward declaring a protocol, for example FireAuth: https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseAuth/Sources/Backend/FIRAuthRequestConfiguration.h#L24. I am able to get things build for now. But I'll change to import if it's safer.

samedson

Looks great. Love the singleton technique.

ncooke3

Adding some review suggestions for missing file copyrights. I also added some feedback in the DD with regard to some of the API names.

ncooke3 · 2023-12-04T22:15:28Z

FirebaseRemoteConfig/Interop/RemoteConfigInterop.swift

+//
+//  File.swift
+//
+//
+//  Created by Themis Wang on 2023-11-16.
+//


Suggested change

//

// File.swift

//

//

// Created by Themis Wang on 2023-11-16.

//

// Copyright 2023 Google LLC

//

// Licensed under the Apache License, Version 2.0 (the "License");

// you may not use this file except in compliance with the License.

// You may obtain a copy of the License at

//

// http://www.apache.org/licenses/LICENSE-2.0

//

// Unless required by applicable law or agreed to in writing, software

// distributed under the License is distributed on an "AS IS" BASIS,

// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

// See the License for the specific language governing permissions and

// limitations under the License.

ncooke3 · 2023-12-04T22:15:43Z

FirebaseRemoteConfig/Interop/RolloutAssignment.swift

+//
+//  File.swift
+//
+//
+//  Created by Themis Wang on 2023-11-16.
+//


Suggested change

//

// File.swift

//

//

// Created by Themis Wang on 2023-11-16.

//

// Copyright 2023 Google LLC

//

// Licensed under the Apache License, Version 2.0 (the "License");

// you may not use this file except in compliance with the License.

// You may obtain a copy of the License at

//

// http://www.apache.org/licenses/LICENSE-2.0

//

// Unless required by applicable law or agreed to in writing, software

// distributed under the License is distributed on an "AS IS" BASIS,

// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

// See the License for the specific language governing permissions and

// limitations under the License.

ncooke3 · 2023-12-04T22:15:54Z

FirebaseRemoteConfig/Interop/RolloutsStateSubscriber.swift

+//
+//  File.swift
+//
+//
+//  Created by Themis Wang on 2023-11-16.
+//


Suggested change

//

// File.swift

//

//

// Created by Themis Wang on 2023-11-16.

//

// Copyright 2023 Google LLC

//

// Licensed under the Apache License, Version 2.0 (the "License");

// you may not use this file except in compliance with the License.

// You may obtain a copy of the License at

//

// http://www.apache.org/licenses/LICENSE-2.0

//

// Unless required by applicable law or agreed to in writing, software

// distributed under the License is distributed on an "AS IS" BASIS,

// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

// See the License for the specific language governing permissions and

// limitations under the License.

themiswang · 2023-12-05T16:16:07Z

Adding some review suggestions for missing file copyrights. I also added some feedback in the DD with regard to some of the API names.

@ncooke3 Thank you for the review!

themiswang · 2023-12-05T19:31:55Z

Finished prototype review, gonna close this pr.

google-oss-bot added api: crashlytics api: remoteconfig labels Nov 22, 2023

samedson reviewed Nov 22, 2023

View reviewed changes

FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.m Outdated Show resolved Hide resolved

samedson reviewed Nov 22, 2023

View reviewed changes

FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.m Outdated Show resolved Hide resolved

samedson reviewed Nov 22, 2023

View reviewed changes

FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.m Show resolved Hide resolved

danasilver reviewed Nov 22, 2023

View reviewed changes

FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.h Outdated Show resolved Hide resolved

themiswang force-pushed the testInterop branch from e95fac6 to a64dbb3 Compare November 22, 2023 21:36

google-oss-bot added the public-api-change label Nov 22, 2023

themiswang force-pushed the testInterop branch from a64dbb3 to d40694f Compare November 22, 2023 22:03

github-actions bot removed the public-api-change label Nov 22, 2023

google-oss-bot added the public-api-change label Nov 22, 2023

tests

1b6f19d

themiswang force-pushed the testInterop branch from d40694f to 1b6f19d Compare November 23, 2023 19:03

github-actions bot removed the public-api-change label Nov 23, 2023

google-oss-bot added the public-api-change label Nov 23, 2023

temp test

44bfe7c

github-actions bot added public-api-change and removed public-api-change labels Nov 23, 2023

themiswang commented Nov 23, 2023

View reviewed changes

samedson reviewed Nov 28, 2023

View reviewed changes

samedson approved these changes Nov 28, 2023

View reviewed changes

ncooke3 reviewed Dec 4, 2023

View reviewed changes

themiswang closed this Dec 5, 2023

firebase locked and limited conversation to collaborators Jan 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests #12133

tests #12133

themiswang commented Nov 22, 2023

google-oss-bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023 •

edited

Loading

themiswang Nov 23, 2023 •

edited

Loading

themiswang Nov 23, 2023 •

edited

Loading

samedson Nov 28, 2023

ncooke3 Dec 4, 2023

ncooke3 Dec 4, 2023 •

edited

Loading

themiswang Dec 5, 2023

samedson left a comment

ncooke3 left a comment

ncooke3 Dec 4, 2023

ncooke3 Dec 4, 2023

ncooke3 Dec 4, 2023

themiswang commented Dec 5, 2023

themiswang commented Dec 5, 2023

-//
-//  File.swift
-//
-//
-//  Created by Themis Wang on 2023-11-16.
-//
+// Copyright 2023 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.

tests #12133

tests #12133

Conversation

themiswang commented Nov 22, 2023

google-oss-bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023 • edited Loading

Apple API Diff Report

FirebaseCrashlytics

Classes

[MODIFIED] FIRCrashlytics

FirebaseRemoteConfig

Classes

FIRRemoteConfig

FIRRemoteConfigValue

themiswang Nov 23, 2023 • edited Loading

Choose a reason for hiding this comment

themiswang Nov 23, 2023 • edited Loading

Choose a reason for hiding this comment

samedson Nov 28, 2023

Choose a reason for hiding this comment

ncooke3 Dec 4, 2023

Choose a reason for hiding this comment

ncooke3 Dec 4, 2023 • edited Loading

Choose a reason for hiding this comment

themiswang Dec 5, 2023

Choose a reason for hiding this comment

samedson left a comment

Choose a reason for hiding this comment

ncooke3 left a comment

Choose a reason for hiding this comment

ncooke3 Dec 4, 2023

Choose a reason for hiding this comment

ncooke3 Dec 4, 2023

Choose a reason for hiding this comment

ncooke3 Dec 4, 2023

Choose a reason for hiding this comment

themiswang commented Dec 5, 2023

themiswang commented Dec 5, 2023

github-actions bot commented Nov 22, 2023 •

edited

Loading

themiswang Nov 23, 2023 •

edited

Loading

themiswang Nov 23, 2023 •

edited

Loading

ncooke3 Dec 4, 2023 •

edited

Loading