Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Addressing Swift 6 issues with Storage's instance management #13445

Merged
merged 6 commits into from
Aug 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FirebaseStorage/Sources/Storage.swift
Original file line number Diff line number Diff line change
Expand Up @@ -283,10 +283,10 @@ import FirebaseCore

/// A map of active instances, grouped by app. Keys are FirebaseApp names and values are
/// instances of Storage associated with the given app.
private static var instances: [String: Storage] = [:]
private nonisolated(unsafe) static var instances: [String: Storage] = [:]
ncooke3 marked this conversation as resolved.
Show resolved Hide resolved

/// Lock to manage access to the instances array to avoid race conditions.
private static var instancesLock: os_unfair_lock = .init()
private nonisolated(unsafe) static var instancesLock: os_unfair_lock = .init()

var host: String
var scheme: String
Expand Down
Loading