Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Disable Auth deprecations warnings in SPM CI #14013

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 1, 2024

I enabled this for CocoaPods a while back and it works pretty well. Incrementally extending this to FirebaseAuth x SPM.

Example of usage:

#if !FIREBASE_CI
@available(
*,
deprecated,
message: "`fetchSignInMethods` is deprecated and will be removed in a future release. This method returns an empty list when Email Enumeration Protection is enabled."
)
#endif // !FIREBASE_CI
@objc open func fetchSignInMethods(forEmail email: String,
completion: (([String]?, Error?) -> Void)? = nil) {

#no-changelog

@ncooke3 ncooke3 marked this pull request as ready for review November 2, 2024 01:05
@ncooke3 ncooke3 enabled auto-merge (squash) November 2, 2024 16:46
@ncooke3 ncooke3 requested a review from andrewheard November 4, 2024 15:07
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! Thanks for including the example in the PR description.

@ncooke3 ncooke3 merged commit 15eb852 into main Nov 4, 2024
37 checks passed
@ncooke3 ncooke3 deleted the nc/infra-auth branch November 4, 2024 15:22
@firebase firebase locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants