Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RCE flow to skip checking status if appVerificationDisabledForTesting is set #14310

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

pashanka
Copy link
Contributor

@pashanka pashanka commented Jan 7, 2025

Discussion

Fix #14242

If the flag is set we will bypass RCE flow and treat it similar to RCE enablement status off.

Testing

Ran PhoneAuthProvider tests with emulator and verified that this error no longer occurs.

@pashanka pashanka marked this pull request as ready for review January 7, 2025 04:52
@paulb777
Copy link
Member

paulb777 commented Jan 7, 2025

Thanks @pashanka. LGTM. @ncooke3 Would you take a look as well?

@paulb777 paulb777 requested a review from ncooke3 January 7, 2025 15:03
@paulb777 paulb777 added this to the 11.7.0 - M158 milestone Jan 7, 2025
@pashanka pashanka merged commit ed5ea20 into main Jan 7, 2025
55 checks passed
@pashanka pashanka deleted the pashanka/fix-recaptcha-test branch January 7, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getRecaptchaConfig 'not implemented' error in Firebase Emulator despite isAppVerificationDisabledForTesting
4 participants