SPM beta docs #6312
Merged
SPM beta docs #6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilson
reviewed
Aug 20, 2020
There was a problem hiding this comment.
Just two small questions then LGTM, thanks for putting it together! One other thing - do you want to add a link to something like Apple's docs on using SwiftPM for other reference? https://developer.apple.com/documentation/xcode/adding_package_dependencies_to_your_app
SwiftPackageManager.md
Outdated
| Choose the Firebase product and any additional products that you want installed | ||
| in your app. | ||
|
|
||
| <img src="docs/resources/SPMChoose.png"> |
There was a problem hiding this comment.
This should be SPMProducts not SPMChoose
| Select the beta branch. | ||
|
|
||
| Note: Starting with the 6.31.0 release, the versions are specified | ||
| in a format like 6.31-spm-beta. We won't support standard repository |
There was a problem hiding this comment.
Should we be using 6.31.0-spm-beta (including the patch version)?
There was a problem hiding this comment.
I'm proposing that we update the 6.31-spm-beta branch with any patches.
ryanwilson
approved these changes
Aug 20, 2020
morganchen12
approved these changes
Aug 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3136
To review, see https://github.com/firebase/firebase-ios-sdk/blob/pb-spm-beta/SwiftPackageManager.md