-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore: query.test.ts: Use a WriteBatch to delete documents rather than a transaction #7415
Firestore: query.test.ts: Use a WriteBatch to delete documents rather than a transaction #7415
Conversation
…nsaction, for simplicity.
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (127,954 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
The two failing GitHub Actions are known, unrelated issues with RTDB that are fixed by #7422. Please ignore them. |
…e/firestore-compat, but leave concurrency at 1.
…ith concurrency=1 so fingers are crossed that it will pass again with concurrency=4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…of a WriteBatch to avoid affecting the local cache. This fixes the bug introduced by #7415 where WriteBatch affects the local cache (which I didn't realize).
…lete documents instead of a transaction This is a port of firebase/firebase-js-sdk#7415 and firebase/firebase-js-sdk#7486
This PR is ported to the Android SDK in firebase/firebase-android-sdk#5167 and the iOS SDK in firebase/firebase-ios-sdk#11615.