Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: query.test.ts: Use a WriteBatch to delete documents rather than a transaction #7415

Merged
merged 9 commits into from
Jul 13, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jul 5, 2023

This PR is ported to the Android SDK in firebase/firebase-android-sdk#5167 and the iOS SDK in firebase/firebase-ios-sdk#11615.

@dconeybe dconeybe self-assigned this Jul 5, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

⚠️ No Changeset found

Latest commit: 64b9f09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 5, 2023

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (47860fe)Merge (7da5bf0)Diff
    browser171 kB171 kB-1 B (-0.0%)
    cordova198 kB198 kB-1 B (-0.0%)
    esm5223 kB223 kB-1 B (-0.0%)
    main168 kB168 kB-1 B (-0.0%)
    module171 kB171 kB-1 B (-0.0%)
    react-native182 kB182 kB-1 B (-0.0%)
  • @firebase/auth/cordova

    TypeBase (47860fe)Merge (7da5bf0)Diff
    browser198 kB198 kB-1 B (-0.0%)
    module198 kB198 kB-1 B (-0.0%)
  • @firebase/auth/internal

    TypeBase (47860fe)Merge (7da5bf0)Diff
    browser181 kB181 kB-1 B (-0.0%)
    esm5237 kB237 kB-1 B (-0.0%)
    main204 kB204 kB-1 B (-0.0%)
    module181 kB181 kB-1 B (-0.0%)
  • @firebase/database

    TypeBase (47860fe)Merge (7da5bf0)Diff
    browser248 kB248 kB-1 B (-0.0%)
    esm5276 kB276 kB-1 B (-0.0%)
    main281 kB281 kB-1 B (-0.0%)
    module248 kB248 kB-1 B (-0.0%)
  • @firebase/firestore

    TypeBase (47860fe)Merge (7da5bf0)Diff
    browser370 kB370 kB-2 B (-0.0%)
    esm5356 kB356 kB-2 B (-0.0%)
    main569 kB569 kB-1 B (-0.0%)
    module370 kB370 kB-2 B (-0.0%)
    react-native370 kB370 kB-2 B (-0.0%)
  • @firebase/firestore-lite

    TypeBase (47860fe)Merge (7da5bf0)Diff
    browser110 kB110 kB-2 B (-0.0%)
    esm5106 kB106 kB-2 B (-0.0%)
    main151 kB151 kB-1 B (-0.0%)
    module110 kB110 kB-2 B (-0.0%)
    react-native110 kB110 kB-2 B (-0.0%)
  • bundle

    27 size changes

    TypeBase (47860fe)Merge (7da5bf0)Diff
    auth (Anonymous)71.1 kB71.1 kB-1 B (-0.0%)
    auth (EmailAndPassword)76.1 kB76.1 kB-1 B (-0.0%)
    auth (GoogleFBTwitterGitHubPopup)97.3 kB97.3 kB-1 B (-0.0%)
    auth (GooglePopup)94.6 kB94.6 kB-1 B (-0.0%)
    auth (GoogleRedirect)94.8 kB94.8 kB-1 B (-0.0%)
    auth (Phone)81.0 kB81.0 kB-1 B (-0.0%)
    database (Append to a list of data)148 kB148 kB-1 B (-0.0%)
    database (Filtering data)147 kB147 kB-1 B (-0.0%)
    database (Listen for child events)164 kB164 kB-1 B (-0.0%)
    database (Listen for value events + Detach listeners)164 kB164 kB-1 B (-0.0%)
    database (Listen for value events)163 kB163 kB-1 B (-0.0%)
    database (Read data once)163 kB163 kB-1 B (-0.0%)
    database (Save data as transactions)166 kB166 kB-1 B (-0.0%)
    database (Sort data)149 kB149 kB-1 B (-0.0%)
    database (Write data)147 kB147 kB-1 B (-0.0%)
    firestore (Persistence)301 kB301 kB-2 B (-0.0%)
    firestore (Query Cursors)239 kB239 kB-2 B (-0.0%)
    firestore (Query)236 kB236 kB-2 B (-0.0%)
    firestore (Read data once)224 kB224 kB-2 B (-0.0%)
    firestore (Realtime updates)226 kB226 kB-2 B (-0.0%)
    firestore (Transaction)202 kB202 kB-2 B (-0.0%)
    firestore (Write data)202 kB202 kB-2 B (-0.0%)
    firestore-lite (Query Cursors)82.9 kB82.9 kB-2 B (-0.0%)
    firestore-lite (Query)79.0 kB79.0 kB-2 B (-0.0%)
    firestore-lite (Read data once)61.1 kB61.1 kB-2 B (-0.0%)
    firestore-lite (Transaction)85.9 kB85.9 kB-2 B (-0.0%)
    firestore-lite (Write data)70.6 kB70.6 kB-2 B (-0.0%)

  • firebase

    TypeBase (47860fe)Merge (7da5bf0)Diff
    firebase-auth-compat.js132 kB132 kB-2 B (-0.0%)
    firebase-auth-cordova.js168 kB168 kB-2 B (-0.0%)
    firebase-auth.js142 kB142 kB-2 B (-0.0%)
    firebase-compat.js774 kB774 kB-6 B (-0.0%)
    firebase-database-compat.js166 kB166 kB-2 B (-0.0%)
    firebase-database.js181 kB181 kB-2 B (-0.0%)
    firebase-firestore-compat.js340 kB340 kB-2 B (-0.0%)
    firebase-firestore-lite.js117 kB117 kB-2 B (-0.0%)
    firebase-firestore.js430 kB430 kB-2 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tkFq1p4GfY.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 5, 2023

Size Analysis Report 1

This report is too large (127,954 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WNAqGgHenN.html

@dconeybe dconeybe marked this pull request as ready for review July 6, 2023 17:18
@dconeybe dconeybe requested review from a team as code owners July 6, 2023 17:18
@dconeybe
Copy link
Contributor Author

dconeybe commented Jul 6, 2023

The two failing GitHub Actions are known, unrelated issues with RTDB that are fixed by #7422. Please ignore them.

@dconeybe dconeybe requested a review from milaGGL July 6, 2023 17:19
@dconeybe dconeybe marked this pull request as draft July 7, 2023 01:13
@dconeybe dconeybe marked this pull request as ready for review July 7, 2023 04:07
…e/firestore-compat, but leave concurrency at 1.
@dconeybe dconeybe marked this pull request as draft July 7, 2023 05:57
…ith concurrency=1 so fingers are crossed that it will pass again with concurrency=4
@dconeybe dconeybe marked this pull request as ready for review July 7, 2023 13:22
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 6b1be2a into master Jul 13, 2023
@dconeybe dconeybe deleted the dconeybe/BloomFilterTestUseWriteBatchToDelete branch July 13, 2023 14:45
dconeybe added a commit that referenced this pull request Jul 20, 2023
…of a WriteBatch to avoid affecting the local cache.

This fixes the bug introduced by #7415 where WriteBatch affects the local cache (which I didn't realize).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants