Fix to test-all .github workflow yaml file. #7640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsNo changes between base commit (eff9530) and merge commit (e591352).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (eff9530) and merge commit (e591352).Test Logs |
hsubox76
approved these changes
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Fixed a misaligned indentation on line #107 of
test-all.yamlthat cause a workflow execution failure in GitHub Action CI.Includes an update to all of the
test-all.ymlchrome installation steps to use thenpxinstall method.There's a Failure in
(Firestore) Node.js and Browser (Chrome) Tests, but this existed even before the npx update (when installing Chrome viaapt-get). See this previous run. Since the Firestore issue still remains, the has been disabled (will skip) for now.Also fixed the a problem setting the max heap size for node. Previous attempts echoed the value to the GITHUB_ENV variable on the command line, but this was producing errors. Changed it to use the worfklow
env:directive and I have confirmed that the enviornment variable exists in the shell runtime (example echo output can be found inrun unit testsstep of this worklfow run).Testing
CI
API Changes
N/A