Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more named db test verification. #7695

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

tom-andersen
Copy link
Contributor

I added this sanity check due to a bug that was reported to me.

@tom-andersen tom-andersen requested review from a team as code owners October 12, 2023 14:05
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: cfcc5fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2023

@tom-andersen tom-andersen requested a review from a team as a code owner October 13, 2023 14:24
@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:%0A - @firebase/firestore%0A%0A Make sure this was intentional.

Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think you should remove the empty changeset file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this changeset file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tom-andersen tom-andersen force-pushed the tomandersen/namedDbImproveTest branch from 2be8772 to 341cb32 Compare October 13, 2023 19:24
@tom-andersen tom-andersen merged commit 40b3b0f into master Oct 16, 2023
41 checks passed
@tom-andersen tom-andersen deleted the tomandersen/namedDbImproveTest branch October 16, 2023 15:54
prameshj pushed a commit that referenced this pull request Nov 13, 2023
* Add more named db test verification.

* Changeset
@firebase firebase locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants