Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TOC array indentation #8637

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Disable TOC array indentation #8637

merged 2 commits into from
Dec 12, 2024

Conversation

dlarocque
Copy link
Contributor

TAP YAML linter now requires there to be no array indentation, so we need to change how we generate our TOC. Fortunately we can do this by just changing a config in js-yaml.

@dlarocque dlarocque requested a review from hsubox76 November 13, 2024 16:50
@dlarocque dlarocque requested review from a team as code owners November 13, 2024 16:50
Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 3bc5eee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 13, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 13, 2024

@dlarocque dlarocque requested a review from egilmorez November 13, 2024 18:07
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

I'd feel even better seeing a staging link though, if practical. Thanks!

@dlarocque dlarocque merged commit 46c91bc into main Dec 12, 2024
34 checks passed
@dlarocque dlarocque deleted the dl/fix-toc branch December 12, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants