Fireperf web vitals #8644
Open
Fireperf web vitals #8644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanatkinson
commented
Nov 18, 2024
bryanatkinson
commented
- Add support for capturing web vitals metrics in Firebase performance for Web (Largest Contentful Paint, Interaction to Next Paint, Cumulative Layout Shift)
- Modifies export to use sendBeacon instead of fetch API, and shifts the upload time to the first time the page is hidden or unloaded.
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (123,441 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
raymondlam
approved these changes
Nov 21, 2024
…for Web. Modifies export to use sendBeacon instead of fetch API, and shifts the upload time to the first time the page is hidden or unloaded.
…load now, so no need to add additional timeouts.
bryanatkinson
force-pushed
the
fireperf-web-vitals
branch
from
fe72ce1 to
4b4d9ad
Compare
… often updates the values at unload time, and os queuing this until the end means those latest values get captured.
raymondlam
approved these changes
Nov 27, 2024
| let getEntriesByTypeStub: SinonStub<[EntryType], PerformanceEntry[]>; | ||
| let setupObserverStub: SinonStub< | ||
| [EntryType, (entry: PerformanceEntry) => void], | ||
| void | ||
| >; | ||
| let createOobTraceStub: SinonStub< | ||
| let createOobTraceStub: SinonSpy< |
There was a problem hiding this comment.
nit: createOobTraceStub -> createOobTraceSpy
| method: 'POST', | ||
| body: JSON.stringify(data) | ||
| }); | ||
| return navigator.sendBeacon(flTransportFullUrl, JSON.stringify(data)); |
There was a problem hiding this comment.
We should have a fall back to fetch if sendBeacon fails (eg. payload is > then the ~64KB limit)
(navigator.sendBeacon && navigator.sendBeacon(flTransportFullUrl, JSON.stringify(data))) ||
fetch(flTransportFullUrl, {
method: 'POST',
body: JSON.stringify(data),
keepalive: true
}
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.