Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to include promise instead of promiselike #8667

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Updated to include promise instead of promiselike #8667

wants to merge 6 commits into from
+40 −45

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Dec 6, 2024

Use Promise instead of PromiseLike

@maneesht maneesht requested review from aashishpatil-g and a team as code owners December 6, 2024 00:51
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9c04231

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/data-connect Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maneesht maneesht requested review from a team as code owners December 6, 2024 00:51
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 6, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/data-connect

    TypeBase (cb4309f)Merge (f24d337)Diff
    browser20.2 kB20.1 kB-125 B (-0.6%)
    main22.1 kB22.0 kB-125 B (-0.6%)
    module20.2 kB20.1 kB-125 B (-0.6%)

  • firebase

    TypeBase (cb4309f)Merge (f24d337)Diff
    firebase-data-connect.js16.7 kB16.7 kB-89 B (-0.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Sdwz2rRfdY.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 6, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/data-connect

    • DataConnect

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.7 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.7 kB-81 B (-0.3%)

    • MUTATION_STR

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.8 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.7 kB-81 B (-0.3%)

    • MutationManager

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.7 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.7 kB-81 B (-0.3%)

    • QUERY_STR

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.7 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.7 kB-81 B (-0.3%)

    • SOURCE_CACHE

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.7 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.7 kB-81 B (-0.3%)

    • SOURCE_SERVER

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.7 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.7 kB-81 B (-0.3%)

    • areTransportOptionsEqual

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.8 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.7 kB-81 B (-0.3%)

    • connectDataConnectEmulator

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.8 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.9 kB29.8 kB-81 B (-0.3%)

    • executeMutation

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.8 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.9 kB29.8 kB-81 B (-0.3%)

    • executeQuery

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.8 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.9 kB29.8 kB-81 B (-0.3%)

    • getDataConnect

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size12.4 kB12.3 kB-81 B (-0.7%)
      size-with-ext-deps37.6 kB37.5 kB-81 B (-0.2%)

    • mutationRef

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.9 kB11.8 kB-81 B (-0.7%)
      size-with-ext-deps29.9 kB29.8 kB-81 B (-0.3%)

    • parseOptions

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.7 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.7 kB-81 B (-0.3%)

    • queryRef

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.9 kB11.8 kB-81 B (-0.7%)
      size-with-ext-deps29.9 kB29.8 kB-81 B (-0.3%)

    • setLogLevel

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.8 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.8 kB-81 B (-0.3%)

    • subscribe

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size13.0 kB12.9 kB-81 B (-0.6%)
      size-with-ext-deps38.1 kB38.1 kB-81 B (-0.2%)

    • terminate

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size11.8 kB11.7 kB-81 B (-0.7%)
      size-with-ext-deps29.8 kB29.8 kB-81 B (-0.3%)

    • toQueryRef

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size12.6 kB12.6 kB-81 B (-0.6%)
      size-with-ext-deps37.8 kB37.7 kB-81 B (-0.2%)

    • validateArgs

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size12.6 kB12.5 kB-81 B (-0.6%)
      size-with-ext-deps37.8 kB37.7 kB-81 B (-0.2%)

    • validateDCOptions

      Size

      TypeBase (cb4309f)Merge (f24d337)Diff
      size12.0 kB11.9 kB-81 B (-0.7%)
      size-with-ext-deps30.0 kB30.0 kB-81 B (-0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pgDnAypLxH.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maneesht @google-oss-bot