Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ts-node dep - needed to read jest.config.ts #8670

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Dec 9, 2024

e2e tests are failing because

$ yarn jest tests/modular.test.ts
$ /home/runner/work/firebase-js-sdk/firebase-js-sdk/e2e/node_modules/.bin/jest tests/modular.test.ts
Error: Jest: Failed to parse the TypeScript config file /home/runner/work/firebase-js-sdk/firebase-js-sdk/e2e/jest.config.ts
  Error: Jest: 'ts-node' is required for the TypeScript configuration files. Make sure it is installed
Error: Cannot find package 'ts-node' imported from /home/runner/work/firebase-js-sdk/firebase-js-sdk/e2e/node_modules/jest-config/build/readConfigFileAndSetRootDir.js

So I added ts-node. Hopefully this works.

@hsubox76 hsubox76 requested a review from a team as a code owner December 9, 2024 22:18
Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 9349365

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit cbec4b9 into main Dec 10, 2024
39 checks passed
@hsubox76 hsubox76 deleted the ch-e2e-fix-2 branch December 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants