Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use versions instead of commits in vertexai responses actions scripts #8702

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

hsubox76
Copy link
Contributor

I think it should be safe to pin these third party Github actions to versions instead of commit hashes. Pinning it to a commit hash results in a lot of renovate PRs every time there's a new commit to that action.

@hsubox76 hsubox76 requested a review from a team as a code owner January 10, 2025 21:03
Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: 09776bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 10, 2025

@DellaBitta
Copy link
Contributor

All for it.

Looks like delete-comment doesn't have a v1 though. :(

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 10, 2025

@hsubox76 hsubox76 merged commit 6a82634 into main Jan 14, 2025
39 checks passed
@hsubox76 hsubox76 deleted the ch-vertex-check branch January 14, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants