Work around Java emulators + WSL connectivity issues. #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
approved these changes
Nov 5, 2020
|
@yuchenshi wow I'm so glad this is (mostly) solved now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes firebase/firebase-tools-ui#332
This affects Firebase CLI running on WSL only. It has an undesirable side effect of breaking IPv6 use cases, but this is arguably better than not being able to use it at all from the host. I don't think we have a way to serve both IPv4 and IPv6 from host until microsoft/WSL#4851 is fixed. See microsoft/WSL#4851 (comment) for the root cause of the issue.
Scenarios Tested
Manually tested by crwilcox@ on WSL2. Verified that Firestore Viewer in host can successfully list and edit data in Firestore emulator in subsystem.
Sample Commands
firebase emulators:startin WSL2.curl http://127.0.0.1:8080/from host to verify (it fails with connection refused without this patch).