fix: Stop timeout on loading code in functions and simply warn #7167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! We're not comfortable getting rid of this timeout fully, so we are going to go with #7176 instead, which will let you configure this timeout by setting FUNCTIONS_DISCOVERY_TIMEOUT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #7165
On a low-spec machine or Windows, it is slower than the actual deployment environment and may take more than 10 seconds to load the source code for functions. ( microsoft/Windows-Dev-Performance#17 )
Scenarios Tested
We now have
emulators:startworking in our production code.Sample Commands