Increase memory for server function on Next.js with image optimization #7940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoortizz
reviewed
Nov 13, 2024
src/frameworks/index.ts
Outdated
| @@ -538,6 +539,12 @@ ${ | |||
|
|
|||
| // TODO move to templates | |||
|
|
|||
| if (frameworksBackend && framework === "next") { | |||
| if (await isUsingImageOptimization(getProjectPath(), ".next")) { | |||
There was a problem hiding this comment.
don't we need to do this only for Next 15?
There was a problem hiding this comment.
The memory issue is happening on Next 14 and 13 as well 🫠
leoortizz
reviewed
Nov 16, 2024
leoortizz
reviewed
Nov 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7940 +/- ##
==========================================
- Coverage 51.19% 51.14% -0.05%
==========================================
Files 423 423
Lines 29544 29580 +36
Branches 6031 6039 +8
==========================================
+ Hits 15125 15130 +5
- Misses 13059 13090 +31
Partials 1360 1360 ☔ View full report in Codecov by Sentry. |
…rebase/firebase-tools into chalosalvador/nextjs-memory-image-opt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands