Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore instructions and convinience script #507

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Firestore instructions and convinience script #507

wants to merge 3 commits into from

Conversation

wu-hui
Copy link

@wu-hui wu-hui commented Oct 27, 2022

No description provided.

@wu-hui wu-hui added the tests-requested: quick Trigger a quick set of integration tests. label Oct 27, 2022
dconeybe
dconeybe reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a few drive-by comments

.gitignore Outdated Show resolved Hide resolved
firestore/CONTRIBUTING.md Outdated Show resolved Hide resolved
firestore/CONTRIBUTING.md Outdated Show resolved Hide resolved
firestore/CONTRIBUTING.md Show resolved Hide resolved
firestore/CONTRIBUTING.md Outdated Show resolved Hide resolved
firestore/CONTRIBUTING.md Show resolved Hide resolved
@wu-hui wu-hui force-pushed the wuandy/FirestoreInstructions branch from c392580 to 2781174 Compare October 28, 2022 16:02
wu-hui
wu-hui commented Oct 28, 2022
View reviewed changes
Copy link
Author

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving-by!

.gitignore Outdated Show resolved Hide resolved
firestore/CONTRIBUTING.md Outdated Show resolved Hide resolved
firestore/CONTRIBUTING.md Outdated Show resolved Hide resolved
firestore/CONTRIBUTING.md Show resolved Hide resolved
firestore/CONTRIBUTING.md Outdated Show resolved Hide resolved
firestore/CONTRIBUTING.md Show resolved Hide resolved
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 28, 2022
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 31, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Oct 31, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit a806a82
Last updated: Mon Oct 31 14:27 PDT 2022
View integration test log & download artifacts

Failures Configs
analytics [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
auth [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
crashlytics [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
database [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
dynamic_links [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
firestore [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
functions [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
installations [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
messaging [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
remote_config [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
storage [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]

@wu-hui wu-hui added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Oct 31, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels Oct 31, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconeybe dconeybe dconeybe left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wu-hui @dconeybe