Skip to content

Commit

Permalink
feat: bump firebase iOS SDK to v11.7.0 (#17011)
Browse files Browse the repository at this point in the history
* feat: bump firebase iOS SDK to `v11.7.0`

* test: reintroduce skipped tests
  • Loading branch information
russellwheatley authored Jan 24, 2025
1 parent 9eac89e commit 2e042ba
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# https://firebase.google.com/support/release-notes/ios
def firebase_sdk_version!()
'11.6.0'
'11.7.0'
end
Original file line number Diff line number Diff line change
Expand Up @@ -904,13 +904,8 @@ void main() {

Exception e = await getError();
expect(e, isA<FirebaseAuthException>());
// Exception code is returning internal-error but the underlying error is "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator."
// This issue on firebase-ios-sdk: https://github.com/firebase/firebase-ios-sdk/issues/14242. Once this is resolved, we ought to reinstate the below.
// It works fine on live project but returns internal-error on emulator.
if (defaultTargetPlatform != TargetPlatform.iOS) {
FirebaseAuthException exception = e as FirebaseAuthException;
expect(exception.code, equals('invalid-phone-number'));
}
FirebaseAuthException exception = e as FirebaseAuthException;
expect(exception.code, equals('invalid-phone-number'));
});

test(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,7 @@ void main() {
},
skip: kIsWeb ||
defaultTargetPlatform == TargetPlatform.macOS ||
defaultTargetPlatform == TargetPlatform.windows
// on iOS, returning an exception but underlying exception is: "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator."
// which might be a result of this issue: https://github.com/firebase/firebase-ios-sdk/issues/14242. Once resolved, try to reinstate.
|| defaultTargetPlatform == TargetPlatform.iOS,
defaultTargetPlatform == TargetPlatform.windows,
); // verifyPhoneNumber not supported on web.

test(
Expand Down

0 comments on commit 2e042ba

Please sign in to comment.