feat(go/plugins/firebase): add retriever, init methods #1470
+1,001
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apascal07
approved these changes
Dec 20, 2024
| if app == nil { | ||
| newApp, err := firebase.NewApp(ctx, nil) | ||
| if state.initted { | ||
| log.Println("firebase.Init: plugin already initialized, returning without reinitializing") |
There was a problem hiding this comment.
We discussed this before, but I don't remember the outcome of the discussion -- are we sure we want to no-op when it's possible there is a different config being passed in?
There was a problem hiding this comment.
I wonder if this is the right behavior or if it should error on subsequent calls. Generally this no-op behavior is only deterministic if you are not passing a configuration that you are expecting to take effect. Here, a no-op means you don't know if the initted config matches what you're expecting.
yup you're right, sorry it got lost across versions of this PR, will look to change
| } | ||
|
|
||
| // Retrievers returns the cached list of retrievers. | ||
| func Retrievers(ctx context.Context) ([]ai.Retriever, error) { |
There was a problem hiding this comment.
Don't need ctx here or above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds retrievers to the Go firebase plugin.
Should resolve #711
Checklist (if applicable):