Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add codelab "Chat with a PDF file" #1471

Merged
merged 16 commits into from
Dec 17, 2024
Merged

docs: add codelab "Chat with a PDF file" #1471

merged 16 commits into from
Dec 17, 2024

Conversation

peterfriese
Copy link
Contributor

This adds a codelab that walks the user through the experience of building a command-line based chat app that allows them to chat with a PDF file.

@peterfriese peterfriese added the docs Improvements or additions to documentation label Dec 9, 2024
@peterfriese peterfriese self-assigned this Dec 9, 2024
@peterfriese peterfriese changed the title Add codelab "Chat with a PDF file" docs: add codelab "Chat with a PDF file" Dec 9, 2024
@peterfriese peterfriese requested review from thedmail and pavelgj and removed request for pavelgj and chrisraygill December 11, 2024 10:35
thedmail
thedmail reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@thedmail thedmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments. I'm going to try and stage this to give it another reading through; there may be a second batch. ;-)

docs/codelabs/codelab-chat-with-a-pdf.md Outdated Show resolved Hide resolved
docs/codelabs/codelab-chat-with-a-pdf.md Outdated Show resolved Hide resolved
docs/codelabs/codelab-chat-with-a-pdf.md Outdated Show resolved Hide resolved
docs/codelabs/codelab-chat-with-a-pdf.md Outdated Show resolved Hide resolved
docs/codelabs/codelab-chat-with-a-pdf.md Outdated Show resolved Hide resolved
docs/codelabs/codelab-chat-with-a-pdf.md Outdated Show resolved Hide resolved
docs/codelabs/codelab-chat-with-a-pdf.md Show resolved Hide resolved
docs/codelabs/codelab-chat-with-a-pdf.md Outdated Show resolved Hide resolved
docs/codelabs/codelab-chat-with-a-pdf.md Outdated Show resolved Hide resolved
docs/codelabs/codelab-chat-with-a-pdf.md Outdated Show resolved Hide resolved
@peterfriese
Fix UK spelling.
9e60856 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Fix typo.
a288778 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Use bullet list for list of providers
75407ff 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Adjust line breaks to 80 colums
cccfed5 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
free -> free of charge
bbd0540 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Comma
9646e32 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Typo
4422ad1 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Use enumerate lists
4c9b052 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Rrewrite for clarity
5a5462a 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Re-write for clarity
6188b2a 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Add extra line for clarity
1a8c5b6 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Use enumerated list
f1ba83a 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
More enumerated lists
16f716d 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese
Periods instead of colons
b3c0438 
Signed-off-by: Peter Friese <[email protected]>
@peterfriese peterfriese requested a review from thedmail December 16, 2024 12:19
@thedmail thedmail merged commit 4618930 into main Dec 17, 2024
4 checks passed
@thedmail thedmail deleted the peterfriese/codelabs/chat-with-a-pdf branch December 17, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedmail thedmail thedmail approved these changes

@pavelgj pavelgj Awaiting requested review from pavelgj

@chrisraygill chrisraygill Awaiting requested review from chrisraygill

@huangjeff5 huangjeff5 Awaiting requested review from huangjeff5

Assignees

@peterfriese peterfriese

Labels
docs Improvements or additions to documentation
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterfriese @thedmail