Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: polish multi-agent example #1476

Merged
merged 8 commits into from
Dec 16, 2024
Merged

chore: polish multi-agent example #1476

merged 8 commits into from
Dec 16, 2024

Conversation

huangjeff5
Copy link
Contributor

Checklist (if applicable):

@huangjeff5 huangjeff5 marked this pull request as ready for review December 10, 2024 00:50
@huangjeff5 huangjeff5 requested a review from pavelgj December 10, 2024 00:50
Copy link
Contributor

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a walkthrough of an existing code sample, and not a hands-on codelab.

While there is nothing wrong with a walkthrough, I would prefer giving people a hand-on experience of creating an agent system themselves, to show them how it's really done.

@huangjeff5 huangjeff5 changed the title chore: polish mult-agent example chore: polish mult-agent example and add codelab Dec 16, 2024
@huangjeff5
Copy link
Contributor Author

This is more of a walkthrough of an existing code sample, and not a hands-on codelab.

While there is nothing wrong with a walkthrough, I would prefer giving people a hand-on experience of creating an agent system themselves, to show them how it's really done.

Makes sense. I think it will take some more work and iteration than I initially thought, so I'm going to work on this and try to simplify it and make it more hands-on, and make a separate PR.

@huangjeff5 huangjeff5 requested review from peterfriese and removed request for peterfriese December 16, 2024 23:34
@huangjeff5 huangjeff5 changed the title chore: polish mult-agent example and add codelab chore: polish mult-agent example Dec 16, 2024
@huangjeff5 huangjeff5 changed the title chore: polish mult-agent example chore: polish multi-agent example Dec 16, 2024
Copy link
Contributor

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge as a sample.

@huangjeff5 huangjeff5 merged commit 9643e44 into main Dec 16, 2024
4 checks passed
@huangjeff5 huangjeff5 deleted the jh-agent branch December 16, 2024 23:46
@huangjeff5 huangjeff5 restored the jh-agent branch December 16, 2024 23:46
@huangjeff5 huangjeff5 deleted the jh-agent branch December 16, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants