fix: fix types related to transactions #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarinvak
reviewed
Jun 6, 2022
src/types.ts
Outdated
| @@ -280,7 +281,7 @@ export interface TransactionResponse { | |||
| status: TransactionStatus; | |||
| txHash: string; | |||
| numOfConfirmations?: number; | |||
| subStatus?: string; | |||
| subStatus?: TransactionStatus; | |||
There was a problem hiding this comment.
this is incorrect, subStatus is not of type TransactionStatus
yarinvak
reviewed
Jun 6, 2022
| customerRefId?: string; | ||
| amountInfo?: AmountInfo; | ||
| feeInfo?: FeeInfo; | ||
| signedMessages?: SignedMessageResponse[]; |
There was a problem hiding this comment.
signedMessages is an optional field
yarinvak
reviewed
Jun 6, 2022
| extraParameters?: any; | ||
| externalTxId?: string; | ||
| destinations?: TransactionResponseDestination[]; | ||
| destinations: TransactionResponseDestination[]; |
There was a problem hiding this comment.
destination is an optional field
There was a problem hiding this comment.
An array is always returned, so it is always defined.
It is likely done this way because that makes the end-user work easier, you can just look through it whether it is empty or not.
yarinvak
suggested changes
Jun 6, 2022
Update interfaces: - InternalWalletAsset - CreateTransactionResponse - TransactionResponse Update comments of functions throwing: - getVaultAccountsWithPageInfo - getTransactionById - validateAddress
ehamery
force-pushed
the
fix/transaction-types
branch
from
7bbe935 to
a77c80b
Compare
ehamery
force-pushed
the
fix/transaction-types
branch
from
5ed9213 to
07d434b
Compare
ehamery
force-pushed
the
fix/transaction-types
branch
from
07d434b to
5fa77bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update interfaces:
Update comments of functions throwing:
Pull Request Description
Some interfaces did not match what the API returns, therefore I fixed them.
Type of change
How Has This Been Tested?
Checklist: