formatted SDK & added NCW endpoints #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idanya
reviewed
Sep 14, 2023
idanya
reviewed
Sep 18, 2023
idanya
reviewed
Sep 19, 2023
idanya
approved these changes
Oct 18, 2023
YoavBZ
reviewed
Oct 18, 2023
Comment on lines
-1726
to
-1787
| def get_users_groups(self) -> List[Dict[str, Any]]: | ||
| """ | ||
| Gets all Users Groups for your tenant | ||
| """ | ||
|
|
||
| url = "/v1/users_groups" | ||
|
|
||
| return self._get_request(url) | ||
|
|
||
| def get_users_group(self, id: str) -> Dict[str, Any]: | ||
| """ | ||
| Gets a Users Group by ID | ||
| @param id: The ID of the User | ||
| """ | ||
|
|
||
| url = f"/v1/users_groups/{id}" | ||
|
|
||
| return self._get_request(url) | ||
|
|
||
| def create_user_group(self, group_name: str, member_ids: Optional[List[str]] = None) -> Dict[str, Any]: | ||
| """ | ||
| Creates a new Users Group | ||
| @param group_name: The name of the Users Group | ||
| @param member_ids: The ids of the Users Group members | ||
| """ | ||
|
|
||
| url = "/v1/users_groups" | ||
|
|
||
| body = { | ||
| "groupName": group_name, | ||
| "memberIds": member_ids | ||
| } | ||
|
|
||
| return self._post_request(url, body) | ||
|
|
||
| def update_user_group(self, id: str, group_name: Optional[str] = None, member_ids: Optional[List[str]] = None) -> Dict[str, Any]: | ||
| """ | ||
| Updates a Users Group | ||
| @param id: The ID of the Users Group | ||
| @param group_name: The name of the Users Group | ||
| @param member_ids: The ids of the Users Group members | ||
| """ | ||
|
|
||
| url = f"/v1/users_groups/{id}" | ||
|
|
||
| body = { | ||
| "groupName": group_name, | ||
| "memberIds": member_ids | ||
| } | ||
|
|
||
| return self._put_request(url, body) | ||
|
|
||
| def delete_user_group(self, id: str) -> None: | ||
| """ | ||
| Deletes a Users Group | ||
| @param id: The ID of the Users Group | ||
| """ | ||
|
|
||
| url = f"/v1/users_groups/{id}" | ||
|
|
||
| return self._delete_request(url) | ||
|
|
There was a problem hiding this comment.
Why did you remove the /users_groups methods?
There was a problem hiding this comment.
It was a mistake, due to the PR existing for a long time, we should put them back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.