Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max total fee param to tx request #192

Merged
merged 2 commits into from
Sep 9, 2024
Merged

add max total fee param to tx request #192

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6a1835
add max tx fee param
yuval-fireblocks Aug 15, 2024
e4cf8cb
rename to maxTotalFee
yuval-fireblocks Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fireblocks_sdk/sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1474,6 +1474,7 @@ def create_transaction(
fee_level=None,
fail_on_low_fee=None,
max_fee=None,
max_tx_fee=None,
gas_limit=None,
idempotency_key=None,
external_tx_id=None,
Expand Down Expand Up @@ -1543,6 +1544,9 @@ def create_transaction(
if max_fee:
body["maxFee"] = max_fee

if max_tx_fee:
body["maxTxFee"] = max_tx_fee

if fail_on_low_fee:
body["failOnLowFee"] = fail_on_low_fee

Expand Down
Loading