Add unit test to not log stdout or stderr fields on create task request #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
add-integration-test-for-stdout-stderr
branch
2 times, most recently
from
db20dea
to
8ec2104
Compare
austinvazquez
changed the title
sondavidb
reviewed
Feb 21, 2024
| testLogger.Level = logrus.DebugLevel | ||
|
|
||
| vmIsReady := make(chan struct{}) | ||
| close(vmIsReady) |
There was a problem hiding this comment.
In this case, the channel is closed after the CreateVM API call is made. So mocking here the VM is ready.
Not that I have found, but open to ideas there. |
austinvazquez
force-pushed
the
add-integration-test-for-stdout-stderr
branch
from
8ec2104
to
cb3b0a8
Compare
| // (*service).Create will fail on (Dir).CreateBundleLink after the log we want to validate. | ||
| _, _ = uut.Create(ctx, createTaskRequest) | ||
|
|
||
| for _, entry := range hook.AllEntries() { |
There was a problem hiding this comment.
For sanity, can you assert that your configured logger is actually logging? Like, check that it logs the task ID.
There was a problem hiding this comment.
Good call, added lines 355 and 358 for this.
austinvazquez
force-pushed
the
add-integration-test-for-stdout-stderr
branch
from
cb3b0a8
to
5f9ef42
Compare
swagatbora90
approved these changes
Feb 21, 2024
In the shim logger use case, the stdout or stderr fields for create task can be the full binary URI and contain sensitive information via environment variables or parameters. Since this is not a clean solution to redact this information, it is best to not log them to disk. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
add-integration-test-for-stdout-stderr
branch
from
5f9ef42
to
135e85a
Compare
sondavidb
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Validates #781
Description of changes:
This change adds a unit test to validate when launching a container with the firecracker runtime the shim implementation will not log the stdout/stderr shim logger binary URI to disk.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.