Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Go 1.13 #363

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Drop Go 1.13 #363

merged 1 commit into from
Oct 13, 2021

Conversation

kzys
Copy link
Contributor

@kzys kzys commented Oct 12, 2021

github.com/go-openapi/runtime's latest version doesn't work with Go
1.13 due to net/http.

Since Go 1.13 is no longer maintained by the Go team, it would be
better to just drop the version rather than asking the package owner
to support the version.

https://pkg.go.dev/net/http#Header.Values

Signed-off-by: Kazuyoshi Kato [email protected]

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github.com/go-openapi/runtime's latest version doesn't work with Go
1.13 due to net/http.

Since Go 1.13 is no longer maintained by the Go team, it would be
better to just drop the version rather than asking the package owner
to support the version.

https://pkg.go.dev/net/http#Header.Values

Signed-off-by: Kazuyoshi Kato <[email protected]>
@Kern--
Copy link
Contributor

Kern-- commented Oct 13, 2021

There is an open issue in go-openapi/runtime that seems to be asking for the maintainers to continue supporting Go 1.13 (go-openapi/runtime#217).

Since Go 1.13 is no longer maintained by the Go team

Neither is Go 1.14 or 1.15. Should we clarify a policy for which go versions are supported or is it too situational?

@kzys
Copy link
Contributor Author

kzys commented Oct 13, 2021

I agree that we should clarify the policy.

Regarding specific Go versions, I'd like to make the package usable on major Linux distributions. The definition of "major" is subjective though. For example, Amazon Linux 2 and Debian 11 (bullseye) only have Go 1.15. So I don't want to drop Go 1.15 support at this time.

@Kern--
Copy link
Contributor

Kern-- commented Oct 13, 2021

Ubuntu 18.04 only has ships up to go 1.13 and Ubuntu 20.04 up to go 1.4.

Follow up from this should be to define support policy which probably also defines which distros we consider to be major and at which versions. I think that decision will apply to firectl and firecracker-containerd as well.

@kzys
Copy link
Contributor Author

kzys commented Oct 13, 2021

firecracker-containerd is slightly easier since containerd upgrades Go somewhat aggressively. This SDK and firectl are harder, or we have more freedom to support which Go versions.

I've cut #364 to define supported Go versions. For now, I'd like to drop Go 1.13, update OpenAPI packages to update mongo-driver.

@kzys kzys merged commit b18499f into firecracker-microvm:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants