Pin version of ltag for go <= v1.15 compatibility #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is the best option I will made changes, plus we should consider to pin a version for each dependency to avoid situation like this one. |
Signed-off-by: Mathis Joffre <[email protected]>
ginglis13
approved these changes
Aug 30, 2022
| @@ -144,6 +144,6 @@ firecracker-clean: | |||
|
|
|||
| lint: deps | |||
| gofmt -s -l . | |||
| $(FC_TEST_DATA_PATH)/ltag -check -v -t .headers | |||
| $(FC_TEST_DATA_PATH)/bin/ltag -check -v -t .headers | |||
There was a problem hiding this comment.
Suggested change
| $(FC_TEST_DATA_PATH)/bin/ltag -check -v -t .headers | |
| $(FC_TEST_BIN_PATH)/ltag -check -v -t .headers |
There was a problem hiding this comment.
Unfortunately, it doesn't work like this in the linter section of buildkite.
Kern--
approved these changes
Aug 30, 2022
kzys
approved these changes
Aug 30, 2022
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mathis Joffre [email protected]
Issue #, if available: #364
Sorry for multiple PR opening I had some troubles with my branches and squashing. This the final PR for this issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.