Pass --level through jailer if set
#574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gudmundur Bjarni Olafsson <[email protected]>
gudmundur
force-pushed
the
jailer-log-level
branch
from
8972ca9
to
fe67294
Compare
This was referenced Jun 12, 2024
|
@swagatbora90 @austinvazquez Any chance y'all could look into it? Seems like you folks are the most recent contributors on AWS side. Thank you! |
sondavidb
approved these changes
Jun 13, 2024
swagatbora90
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #534
Description of changes: In upgrading Firecracker, I noticed a handful of new log lines regarding invocations of the Firecracker API. I've traced them down to logging the API call, and a series of successful request messages. To reduce the amount of log output from Firecracker, I tried adjusting the log level to
Warning, but it had no effect as thejailerand the SDK do not seem to respect the setting if no path or fifo is used. This change changes thejailerso that it will propagate the level through to the binary's--levelflag if set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.