fix: clarify comments in kani module #5000
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QUEUE_END is the address of the first byte past the end of our queue indeed, but the queue doesnt start at 0 (it starts at QUEUE_BASE_ADDRESS, which is 512), and thus GUEST_MEMORY_SIZE was 512 byte too large, because it assumed QUEUE_END was also the size of the queue. Closes firecracker-microvm#4997 Reported-by: Matias Ezequiel Vara Larsen <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
kani-comment-fix
branch
from
622913d to
081321a
Compare
roypat
added
the
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5000 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 245 245
Lines 26697 26697
=======================================
Hits 22194 22194
Misses 4503 4503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
approved these changes
Jan 20, 2025
kalyazin
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QUEUE_END is the address of the first byte past the end of our queue indeed, but the queue doesnt start at 0 (it starts at QUEUE_BASE_ADDRESS, which is 512), and thus GUEST_MEMORY_SIZE was 512 byte too large, because it assumed QUEUE_END was also the size of the queue.
Closes #4997
Reported-by: Matias Ezequiel Vara Larsen [email protected]
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.