FunctionMixin _ad_mul and _ad_add use Function operations not Vector …

…operations
firedrakeproject · Oct 25, 2024 · 4fd0d63 · 4fd0d63
1 parent 6ca034f
commit 4fd0d63
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/firedrake/adjoint_utils/function.py b/firedrake/adjoint_utils/function.py
@@ -361,16 +361,12 @@ def _ad_dim(self):
         return self.function_space().dim()
 
     def _ad_imul(self, other):
-        vec = self.vector()
-        vec *= other
+        self *= other
+        return self
 
     def _ad_iadd(self, other):
-        vec = self.vector()
-        ovec = other.vector()
-        if ovec.dat == vec.dat:
-            vec *= 2
-        else:
-            vec += ovec
+        self += other
+        return self
 
     def _ad_function_space(self, mesh):
         return self.ufl_function_space()