Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Regresson 2 #3602

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Performance Regresson 2 #3602

wants to merge 1 commit into from

Conversation

JDBetteridge
Copy link
Member

Description

The performance regression we were seeing for Python 3.12 seems to have hit master, clearly this isn't a Python/Ubuntu version issue.

@connorjward
Copy link
Contributor

This doesn't seem to have fixed the issue...

@connorjward
Copy link
Contributor

This doesn't seem to have fixed the issue...

Or maybe it does? There is so much variability in our CI run times.

@JDBetteridge
Copy link
Member Author

The runners seem pretty idle at the moment, I wonder if this is something else

@connorjward
Copy link
Contributor

The runners seem pretty idle at the moment, I wonder if this is something else

The coverage issue we recently found did seem to be specific to Python 3.12, so I wouldn't be surprised if it were something else. Probably some upstream package has just changed version.

@JDBetteridge
Copy link
Member Author

The runners seem pretty idle at the moment, I wonder if this is something else

The coverage issue we recently found did seem to be specific to Python 3.12, so I wouldn't be surprised if it were something else. Probably some upstream package has just changed version.

😧

@JDBetteridge JDBetteridge force-pushed the JDBetteridge/ci_performance_regression branch from 5bb6b0e to 1ec1cde Compare May 31, 2024 14:21
@JDBetteridge JDBetteridge changed the title What happens if we turn off coverage Performance Regresson 2 May 31, 2024
@JDBetteridge JDBetteridge mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjward connorjward Awaiting requested review from connorjward

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JDBetteridge @connorjward