Apply Diriclet boundary on the Cofunction RHS. #3754
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
reviewed
Sep 2, 2024
| for coeff in coefficients: | ||
| if isinstance(coeff, Cofunction): | ||
| # Apply the DirichletBC to the right hand side of the equation. | ||
| dbc.apply(coeff) |
There was a problem hiding this comment.
This does not look right. The residual form might contain many cofunctions in function spaces different from the one of the solution. This should be done before calling the solver, and only on the Cofunction RHS. Also it is likely that you need dbc.zero() instead of dbc.apply(). Also see the comment I left in #3662
pbrubeck
reviewed
Sep 2, 2024
| u = Function(space, name="u") | ||
| problem = LinearVariationalProblem( | ||
| inner(trial, test) * dx, b, u, | ||
| DirichletBC(space, 0.0, "on_boundary")) |
There was a problem hiding this comment.
The test should have non-homogeneous bcs
jrmaddison
reviewed
Sep 3, 2024
| for coeff in coefficients: | ||
| if isinstance(coeff, Cofunction): | ||
| # Apply the DirichletBC to the right hand side of the equation. | ||
| dbc.apply(coeff) |
There was a problem hiding this comment.
This will have side effects on Cofunctions in the problem definition.
u = Function(space, name="u")
b = Cofunction(space.dual(), name="b")
...
problem = LinearVariationalProblem(
inner(trial, test) * dx, b, u, DirichletBC(space, 1, "on_boundary"))
assert b in problem.F.coefficients() # passes
|
To address #3498? |
Yes. It is just a starting point. I still do not know how to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description