Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move both ML frameworks from vanilla to firedrake #3778

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Move both ML frameworks from vanilla to firedrake #3778

merged 1 commit into from
Sep 25, 2024

Conversation

JDBetteridge
Copy link
Member

Description

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8053 ran6471 passed1582 skipped0 failed

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8059 ran7273 passed786 skipped0 failed

@JDBetteridge JDBetteridge marked this pull request as ready for review September 23, 2024 11:37
JHopeCollins
JHopeCollins approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this seems like the sensible thing to do.

@JDBetteridge JDBetteridge merged commit 9b90c70 into master Sep 25, 2024
12 checks passed
@JDBetteridge JDBetteridge deleted the JDBetteridge/remove_ml_from_vanilla branch September 25, 2024 15:05
pbrubeck pushed a commit that referenced this pull request Oct 8, 2024
@JDBetteridge @pbrubeck
Move both ML frameworks from vanilla to firedrake (#3778)
83ee1fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JHopeCollins JHopeCollins JHopeCollins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JDBetteridge @JHopeCollins