Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix point location in parallel #3804

Closed
wants to merge 7 commits into from
Closed

Conversation

connorjward
Copy link
Contributor

Description

I believe that this fixes #3151 and supersedes #3293. It certainly seems to fix this issue on my machine.

Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8078 ran6459 passed1582 skipped37 failed

Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8084 ran7262 passed786 skipped36 failed

@connorjward
Copy link
Contributor Author

Turns out that this is harder than expected. With my changes, if we consider the interval mesh

           p0   |      p1
        o-----o | -----o-----o
                |

and want to locate points A and B on p0 (note the extra cell from p1 is not visible)

           p0   |   p1
        o-----o | -----o
                |  A     B

then our strategy for identifying missing points means that both A and B are considered as being claimed by 'cells that we can't see' and both are removed. This is clearly wrong.

Unfortunately I can't currently think of a way to fix this in a non-invasive manner at present. I do have some general thoughts:

  • Point location should probably not be being done for ghost cells. IMO those should be handled by the other process and communicated over.
  • We should look to use star forests more as the existing approach, with each process seeing all points, is not very scalable.

@connorjward connorjward marked this pull request as draft October 18, 2024 13:36
@connorjward
Copy link
Contributor Author

Closing as this was poorly thought out (though in my defence this is extremely confusing). I will attempt to get #3293 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Cross mesh interpolation breaks for parallel nested meshes
1 participant