Spike support for block device option #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abejgonzalez
requested changes
Apr 19, 2024
wlutil/launch.py
Outdated
| raise ValueError("Spike does not support disk-based configurations") | ||
| riscv_lib_path = os.getenv('RISCV') | ||
| if not os.path.isfile(riscv_lib_path+'/lib/libspikedevices.so'): | ||
| raise ValueError("Spike does not support disk-based configurations without libspikedevices.so") |
There was a problem hiding this comment.
Suggested change
| raise ValueError("Spike does not support disk-based configurations without libspikedevices.so") | |
| raise ValueError("Spike does not support disk-based configurations without libspikedevices.so installed by Chipyard") |
wlutil/launch.py
Outdated
Comment on lines
39
to
40
| riscv_lib_path = os.getenv('RISCV') | ||
| if not os.path.isfile(riscv_lib_path+'/lib/libspikedevices.so'): |
There was a problem hiding this comment.
If 'RISCV' doesn't exist this returns None so the next line will break.
wlutil/launch.py
Outdated
|
|
||
| if 'spike' in config: | ||
| spikeBin = str(config['spike']) | ||
| else: | ||
| spikeBin = 'spike' | ||
|
|
||
| cmd = [spikeBin, | ||
| config.get('spike-args', ''), | ||
| spikeArgs, # config.get('spike-args', ''), |
There was a problem hiding this comment.
Typo. You still want to append the spike-args given by the config
| ' -p' + str(config['cpus']), | ||
| ' -m' + str(int(config['mem'] / (1024*1024)))] | ||
|
|
There was a problem hiding this comment.
Can you check that the docs don't need to be updated as well (maybe just grep around for spike and see what shows up)?
There was a problem hiding this comment.
Can you check the changes?
junsunchoi
force-pushed
the
spike-blkdev
branch
from
558f9c6 to
3bbabcd
Compare
abejgonzalez
previously approved these changes
Apr 19, 2024
Co-authored-by: Abraham Gonzalez <[email protected]>
abejgonzalez
approved these changes
Apr 19, 2024
| for Spike (that binary will boot on Qemu and FireSim as well). The build process | ||
| proceeds as follows: | ||
| Spike, Qemu, and FireSim. Spike now supports a disk. In order to use a disk, | ||
| ``libspikedevices.so`` should be installed by Chipyard to the ``RISCV`` library path (i.e. ``$RISCV/lib`). |
There was a problem hiding this comment.
Suggested change
| ``libspikedevices.so`` should be installed by Chipyard to the ``RISCV`` library path (i.e. ``$RISCV/lib`). | |
| ``libspikedevices.so`` should be installed by Chipyard to the ``RISCV`` library path (i.e. ``$RISCV/lib``). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for running spike with block device option when typing "marshal launch"